Zha0q1 commented on a change in pull request #15210: [WIP] Custom Operator
Profiling Enhancement
URL: https://github.com/apache/incubator-mxnet/pull/15210#discussion_r292650120
##########
File path: src/profiler/profiler.h
##########
@@ -1149,8 +1158,20 @@ struct ProfileOperator : public ProfileEvent {
: ProfileEvent(name)
, as_task_(name, &domain_)
, name_(name)
- , attributes_(attributes) {
- SetCategories(domain_.name());
+ , attributes_(attributes)
+ , profiling_operator(true)
+ , profiling_task(true) {
+ if (strcmp(name, "CustomOperator") == 0) {
+ profiling_operator = false;
+ profiling_task = false;
+ } else if (strcmp(name, "Custom") == 0) {
+ profiling_task = false;
+ } else if (std::string(name).find("::") != std::string::npos) {
+ as_task_.setDomain(&custom_op_domain);
+ SetCategories(custom_op_domain.name());
Review comment:
Yes the names are correct. But we still need to set the domain here to
"Custom Operator" if the operator turns out to be a "sub-operator", that is, an
operator called by a custom operator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
