anirudh2290 commented on a change in pull request #15118: Conversion from FP32
model to Mixed Precision model
URL: https://github.com/apache/incubator-mxnet/pull/15118#discussion_r293176710
##########
File path: src/c_api/c_api_symbolic.cc
##########
@@ -810,6 +810,156 @@ int MXQuantizeSymbol(SymbolHandle sym_handle,
API_END_HANDLE_ERROR(delete s);
}
+int MXReducePrecisionSymbol(SymbolHandle sym_handle,
+ SymbolHandle *ret_sym_handle,
+ mx_uint num_args,
+ const int *arg_type_data,
+ mx_uint num_ind_ptr,
+ const int* ind_ptr,
+ const int *target_dtype,
+ const mx_uint num_target_dtype_op_names,
+ const mx_uint num_fp32_op_names,
+ const mx_uint num_widest_dtype_op_names,
+ const mx_uint num_conditional_fp32_op_names,
+ const mx_uint num_excluded_symbols,
+ const mx_uint num_model_params,
+ const char **target_dtype_op_names,
+ const char **fp32_op_names,
+ const char **widest_dtype_op_names,
+ const char **conditional_fp32_op_names,
+ const char **excluded_symbols,
+ const char **param_names,
+ const char **param_vals,
+ const char **model_param_names,
+ const char **arg_names) {
+ nnvm::Symbol *s = new nnvm::Symbol();
+ API_BEGIN();
+ nnvm::Symbol *sym = static_cast<nnvm::Symbol *>(sym_handle);
+ nnvm::Graph g = Symbol2Graph(*sym);
+ std::unordered_set<std::string> target_dtype_ops;
+ std::unordered_set<std::string> fp32_ops;
+ std::unordered_set<std::string> widest_dtype_ops;
+ std::unordered_set<std::string> excluded_syms;
+ std::unordered_set<std::string> model_params;
+ std::unordered_map<std::string,
+ std::unordered_map<std::string,
+ std::vector<std::string>>>
conditional_fp32_ops;
+ int target_dt = *target_dtype;
+
+ for (size_t i = 0; i < num_target_dtype_op_names; ++i) {
+ target_dtype_ops.emplace(target_dtype_op_names[i]);
+ }
+ for (size_t i = 0; i < num_fp32_op_names; ++i) {
+ fp32_ops.emplace(fp32_op_names[i]);
+ }
+ for (size_t i = 0; i < num_widest_dtype_op_names; ++i) {
+ widest_dtype_ops.emplace(widest_dtype_op_names[i]);
+ }
+ for (size_t i = 0; i < num_excluded_symbols; ++i) {
Review comment:
i think these C APIs will be mostly used by developers from the frontend,
and we just expect the len of excluded_symbols to be passed correctly. We don't
have any such checks for any other C APIs, and I think it is an acceptable
tradeoff to make.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
