apeforest commented on a change in pull request #15210: Custom Operator
Profiling Enhancement
URL: https://github.com/apache/incubator-mxnet/pull/15210#discussion_r295532838
##########
File path: src/profiler/profiler.h
##########
@@ -1149,8 +1158,15 @@ struct ProfileOperator : public ProfileEvent {
: ProfileEvent(name)
, as_task_(name, &domain_)
, name_(name)
- , attributes_(attributes) {
- SetCategories(domain_.name());
+ , attributes_(attributes)
+ , profiling_operator_(strcmp(name, "Dummy_Wait"))
+ , profiling_task_(strcmp(name, "Dummy_Wait") && strcmp(name, "Custom")) {
Review comment:
"Dummy_Wait" is being used in multiple places. It's better to make this a
constant string in the header file instead of plain string here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
