mikemwx commented on a change in pull request #15277: [Numpy] Numpy argsort
URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r295611691
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -580,18 +580,37 @@ void ArgSort(const nnvm::NodeAttrs& attrs,
const std::vector<OpReqType>& req,
const std::vector<TBlob>& outputs) {
const ArgSortParam& param = nnvm::get<ArgSortParam>(attrs.parsed);
- TopKParam topk_param;
- topk_param.axis = param.axis;
- topk_param.is_ascend = param.is_ascend;
- topk_param.k = 0;
- topk_param.dtype = param.dtype;
- topk_param.ret_typ = topk_enum::kReturnIndices;
- MXNET_NO_FLOAT16_TYPE_SWITCH(inputs[0].type_flag_, DType, {
- MSHADOW_TYPE_SWITCH(param.dtype, IDType, {
- TopKImpl<xpu, DType, IDType>(ctx.run_ctx,
- ctx.requested[0], req, inputs[0], outputs,
topk_param);
+
+ if (inputs[0].shape_.ndim() == 0) {
+ // Scalar tensor only accept axis of value 0, -1 or None
+ CHECK(!static_cast<bool>(param.axis) || param.axis.value() == -1 ||
param.axis.value() == 0)
+ << "Axis can only be -1 or 0 for scalor tensor";
Review comment:
extra space added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
