haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort
URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r299844023
##########
File path: python/mxnet/numpy/multiarray.py
##########
@@ -778,13 +778,18 @@ def topk(self, *args, **kwargs):
"""
raise AttributeError('mxnet.numpy.ndarray object has no attribute
topk')
- def argsort(self, *args, **kwargs):
+ def argsort(self, axis=-1, kind='quicksort', order=None): # pylint:
disable=arguments-differ
Review comment:
I think if `kind` is not supported at all you should default it to something
like None.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
