haojin2 commented on a change in pull request #15519: [Numpy] arctan2, a new
branch for pr.
URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r302927529
##########
File path: src/operator/numpy/np_elemwise_broadcast_op.cc
##########
@@ -198,5 +198,74 @@
MXNET_OPERATOR_REGISTER_NP_BINARY_SCALAR(_npi_minimum_scalar)
.set_attr<FCompute>("FCompute<cpu>", BinaryScalarOp::Compute<cpu,
mshadow_op::minimum>)
.set_attr<nnvm::FGradient>("FGradient",
ElemwiseGradUseIn{"_backward_minimum_scalar"});
+inline bool Arctan2OpType(const nnvm::NodeAttrs& attrs,
+ std::vector<int>* in_attrs,
+ std::vector<int>* out_attrs){
Review comment:
```c++
inline bool Arctan2OpType(const nnvm::NodeAttrs& attrs,
std::vector<int>* in_attrs,
std::vector<int>* out_attrs){
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
