larroy commented on issue #15625: Minor refactor of fully connected. URL: https://github.com/apache/incubator-mxnet/pull/15625#issuecomment-515351121 The repeated logic is factored out for readability, does every refactor have to be justified with performance impact? Maintainability and code clarity are also important. If you look at the second order gradient code, this functionality is repeated multiple times, so it makes sense to factor out in a separate function. Are you against this principle or what is the cause for the negative unspecific feedback on this PR? Are you suggesting the PR should be closed? You asked specifically to make a separate PR for this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
