ptrendx commented on a change in pull request #15285: Graph dumper URL: https://github.com/apache/incubator-mxnet/pull/15285#discussion_r307887745
########## File path: src/nnvm/graph_dump.cc ########## @@ -0,0 +1,83 @@ + /* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2019 by Contributors + * \file graph_dump.cc + * \brief Utilities to introspect and print the execution graph + * \author Pedro Larroy + */ + +#include "./graph_dump.h" +#include <vector> +#include <string> +#include "nnvm/graph.h" + +using std::vector; +using std::string; +using namespace std; + +using namespace nnvm; + +namespace { + +std::string unnamed(const std::string &s) { Review comment: I don't think you need an atomic counter for this - just a map that maps the `std::string` to list of `Node*` would be enough to differentiate whether your name is unique or not and what number you need to add to it. There is nothing (unfortunately) in MXNet preventing you from naming your nodes or variables the same in the same graph. I agree that head grads should have a name, I actually did similar change in my pointwise fusion PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
