larroy commented on a change in pull request #15331: [fix] missing input log
higher order.
URL: https://github.com/apache/incubator-mxnet/pull/15331#discussion_r307949325
##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -1117,15 +1117,15 @@
MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU_DR(_backward_log10,
unary_bwd<mshadow_op::log10_grad>)
.set_attr<nnvm::FGradient>("FGradient",
[](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) {
- // ograds[0]: dL/dxgrad
+ // ograds[0]: dL/dygrad
Review comment:
@kshitij12345 I think what you write makes sense. I'm also unsure about
notations, maybe you can come with a better one. If not maybe we leave the
comment out, so we can merge the PR, as the code seems to do what's needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
