larroy commented on a change in pull request #15528: Add AMP Conversion support
for BucketingModule
URL: https://github.com/apache/incubator-mxnet/pull/15528#discussion_r308442891
##########
File path: python/mxnet/module/bucketing_module.py
##########
@@ -335,12 +339,16 @@ def bind(self, data_shapes, label_shapes=None,
for_training=True,
self._grad_req = grad_req
symbol, data_names, label_names =
self._call_sym_gen(self._default_bucket_key)
- module = Module(symbol, data_names, label_names, logger=self.logger,
- context=self._context,
work_load_list=self._work_load_list,
- fixed_param_names=self._fixed_param_names,
- state_names=self._state_names,
- group2ctxs=self._group2ctxs,
- compression_params=self._compression_params)
+ module = None
+ if not self._default_bucket_key in self._buckets:
Review comment:
do you have to check that _default_bucket_key is set? If it's none it
shouldn't be in the dictionary I assume.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
