zoeygxy commented on a change in pull request #15942: Refines NDArray indexing
and adds numpy ndarray indexing [READY FOR REVIEW]
URL: https://github.com/apache/incubator-mxnet/pull/15942#discussion_r317918976
##########
File path: src/operator/tensor/matrix_op-inl.h
##########
@@ -1016,7 +1024,11 @@ void SliceAssignOpForward(const nnvm::NodeAttrs& attrs,
const SliceParam& param = nnvm::get<SliceParam>(attrs.parsed);
MXNET_NDIM_SWITCH(data.ndim(), ndim, {
common::StaticArray<index_t, ndim> begin, end, step;
- GetIndexRange(data.shape_, param.begin, param.end, param.step, &begin,
&end, &step);
+ bool non_zero_shape = GetIndexRange(data.shape_, param.begin, param.end,
param.step,
Review comment:
Fixed. Thx!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
