benhe2011 commented on a change in pull request #15811: [MXNET-891] Support
tuple of scales in upsample operator
URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r318234175
##########
File path: src/operator/nn/upsampling.cc
##########
@@ -58,17 +61,19 @@ static bool UpSamplingShape(const nnvm::NodeAttrs& attrs,
}
} else {
CHECK_EQ(in_shape->size(), 2U) << "Input:[data, weight]";
+ CHECK_EQ(scale_h, scale_w) <<
+ "UpSamplingBilinear: Scale should be the same along all dimensions for
bilinear upsampling";
CHECK_EQ(dshape.ndim(), 4U) << \
"UpSamplingBilinear: Input data should be 4D in (batch, channel, y, x)";
if (!shape_is_known(dshape)) return false;
- int kernel = 2 * param_.scale - param_.scale % 2;
+ int kernel = static_cast<int>(2.0 * scale_h - ::fmod(scale_h, 2));
Review comment:
Didn't think of that--thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
