anirudh2290 commented on a change in pull request #15886: Graph Partition API
URL: https://github.com/apache/incubator-mxnet/pull/15886#discussion_r318260613
 
 

 ##########
 File path: python/mxnet/symbol/symbol.py
 ##########
 @@ -1437,6 +1437,54 @@ def _gen_atomic_symbol(self):
         return Symbol(handle)
 
 
+    def optimize_for(self, backend, args=None, **kwargs):
 
 Review comment:
   Thanks for the partial inference.
   > Would this be acceptable, or can you explain the need for it be available 
immediately?
   
   This is useful even for debugging a smaller hand created model where you 
want to provide shapes and types dict.
   
   My question for the reasoning was also because this is kind of an implicit 
api. I myself as a user would prefer an explicit api with a flag to 
infer_shape_type, and then provide args or shape_dict/type_dict.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to