samskalicky commented on a change in pull request #16131: Fix for duplicate subgraph inputs/outputs URL: https://github.com/apache/incubator-mxnet/pull/16131#discussion_r323517546
########## File path: src/operator/subgraph/subgraph_property.h ########## @@ -296,8 +296,20 @@ class SubgraphProperty { */ virtual void ConnectSubgraphOutputs(const nnvm::NodePtr subgraph_node, std::vector<nnvm::NodeEntry*>* output_entries) const { + // Collapse output_entries pointing to same NodeEntry Review comment: Any suggestion on how to do this without creating a map or changing the interface/API of createSubgraphOutputs? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services