ciyongch commented on a change in pull request #16141: [mkldnn-v1.0] Add
MKL-DNN Convolution
URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324465796
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -126,13 +127,12 @@ mkldnn::convolution_forward::primitive_desc
GetConvFwdImpl(const MKLDNNConvFullP
if (param.conv_param.dilate.ndim() == 0 && bias_md_ptr == nullptr) {
mkldnn::convolution_forward::desc desc(prop,
mkldnn::algorithm::convolution_direct, data_md,
- weight_md, out_md, strides,
padding, padding,
- mkldnn::padding_kind::zero);
Review comment:
Is `padding_kind` disabled or `zero` becomes default option from MKL-DNN
v1.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
