TaoLv commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN
Convolution
URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324531557
##########
File path: src/common/exec_utils.h
##########
@@ -59,15 +59,15 @@ inline bool SetupDefaultBlobsIn(const
std::vector<NDArray>& src,
for (size_t i = 0; i < src.size(); i++) {
auto& nd = src[i];
bool is_default = nd.storage_type() == kDefaultStorage;
-#if MXNET_USE_MKLDNN == 1
+#if MXNET_USE_MKLDNN == 100
Review comment:
No. Here we simply use 100 and 1 to distinguish the code for MKL-DNN v0.x
and v1.x so we don't need to remove v0.x integration code and hence convenient
to review. When merging this branch back to master, we will change all
`MXNET_USE_MKLDNN == 100` back to `MXNET_USE_MKLDNN == 1`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
