ChaiBapchya commented on a change in pull request #16356: Fix atol for test_preloaded_multi_sgd URL: https://github.com/apache/incubator-mxnet/pull/16356#discussion_r330706625
########## File path: tests/python/gpu/test_operator_gpu.py ########## @@ -396,7 +396,7 @@ def _assert_all_almost_equal(lhs_list, rhs_list, rtol, atol): assert_almost_equal(lhs.asnumpy(), rhs.asnumpy(), rtol=rtol, atol=atol) if dtype == 'float16': rtol = 1e-3 - atol = 1e-3 + atol = 1e-2 else: rtol = 1e-5 atol = 1e-6 Review comment: what about when its !float16? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services