ccollins476ad commented on a change in pull request #351: Bt5 extended
advertising - host part
URL:
https://github.com/apache/incubator-mynewt-core/pull/351#discussion_r124359262
##########
File path: net/nimble/host/src/ble_gap.c
##########
@@ -2154,6 +2155,66 @@ ble_gap_disc_tx_params(uint8_t own_addr_type,
return 0;
}
+#if MYNEWT_VAL(BLE_EXT_ADV)
+static int
+ble_gap_ext_disc_tx_params(uint8_t own_addr_type, uint8_t filter_policy,
+ const struct ble_hs_hci_ext_scan_param *uncoded_params,
+ const struct ble_hs_hci_ext_scan_param *coded_params)
+{
+ uint8_t buf[BLE_HCI_CMD_HDR_LEN + BLE_HCI_LE_EXT_SCAN_BASE_LEN +
+ 2 * BLE_HCI_LE_EXT_SCAN_SINGLE_PARAM_LEN];
+ uint8_t phy_mask = 0;
+ struct ble_hs_hci_ext_scan_param param[2] = {0};
Review comment:
I'm sorry to cause so much trouble with that nitpick, but I don't think this
will compile. Since it's an array, you need two initializers, e.g., `{{0}}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
