ccollins476ad commented on issue #351: Bt5 extended advertising - host part URL: https://github.com/apache/incubator-mynewt-core/pull/351#issuecomment-311719642 It seems like a lot of YAML code just to create a setting that can't be changed! I already spoke my piece on this, so I am not going to get too hung up on it, but now I really don't understand the point of the `BLE_LL_CFG_FEAT_LL_EXT_ADV` setting. If I understand correctly, its default value is equal to BLE_EXT_ADV, and any attempt to change it to something else will result in a newt error (restriction violation). Wouldn't it all be simpler to just remove this setting and use BLE_EXT_ADV everywhere instead? I understand the need to maintain consistency, but I am not convinced that argument applies here. It would maintain consistency to provide an option that the user can actually change. Providing an option that elicits an error if you try to change it just strikes me as confusing. Anyway, that is just my opinion. If you and Will prefer the current implementation, then I am fine with it being merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
