cwanda commented on issue #361: Shell improvements before 1.1 URL: https://github.com/apache/mynewt-core/pull/361#issuecomment-312908058 The two changes above look good. Thanks This comment is not related to the changes above: Please add conditional include #if MYNEWT_VAL(SHELL_OS_MODULE) around the shell_os.c code #if MYNEWT_VAL(SHELL_PROMPT_MODULE) around the shell_prompt.c code. We have a tutorial that recommends users to disable SHELL features as a way to reduce application code size. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
