ccollins476ad commented on issue #216: Documetation updates for Bluetooth 5 URL: https://github.com/apache/mynewt-site/pull/216#issuecomment-314904564 A few more comments: * ble_gap_ext_disc * duration parameter * It would be more helpful to be explicit about the units (10ms), rather than pointing to the spec. * BLE_HS_FOREVER won't work here since it is defined as -1. 0 is the correct value here. (Aside: perhaps this function should take an int32_t expressing the number of milliseconds to be compatible with the old API). * ble_gap_ext_conn * The peer_addr parameter mentions the white list, but I don't see how to specify that the white list should be used. Pass a null peer_addr? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
