ccollins476ad commented on a change in pull request #472: Sensor evq URL: https://github.com/apache/mynewt-core/pull/472#discussion_r131783476
########## File path: hw/sensor/syscfg.yml ########## @@ -40,3 +40,7 @@ syscfg.defs: SENSOR_OIC_OBS_RATE: description: 'Set OIC server observation rate in milli seconds' value: 1000 + + SENSOR_MGR_EVQ: + description: 'Specify the eventq to be used by sensor mgr' + value: 0 Review comment: Should the default value of `SENSOR_MGR_EVQ` be blank, rather than `0`? The code uses `#ifdef` to check this setting, and a value of 0 is considered defined. You can specify an empty value like this: ``` SENSOR_MGR_EVQ: description: 'Specify the eventq to be used by sensor mgr' value: ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services