wes3 commented on issue #498: nordic: LF clock modifications URL: https://github.com/apache/mynewt-core/pull/498#issuecomment-324729774 Regarding Marko's comment: I have to say I really do not like the name/location of hal_system_clock_start(). I did not want to make that change as well here (not quite sure why other than not making too many changes all at once). I guess also I was not sure what to do. I was thinking that the code to turn on the clock would exist only in hal_bsp.c as a static function to be honest. This way we could remove the proto from hw/hal and not have it in mcu at all. I do agree with you though Marko: the current code should get modified to remove hal_system_clock_start() for hw/hal. Another possible issue with this change is that the code now always uses the LFCLK. I do not think this a big deal as generally I suspect folks will use nordic platforms w/BLE but I could envision cases where an application does not care about power consumption and wants to use the HFCLK for everything. This is currently not possible and if folks want to do that they are going to have to modify the code to handle this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
