ccollins476ad commented on a change in pull request #552: native-armv7; stack
initialization
URL: https://github.com/apache/mynewt-core/pull/552#discussion_r139574829
##########
File path: kernel/os/src/arch/sim-armv7/os_arch_stack_frame.s
##########
@@ -40,6 +40,7 @@ os_arch_frame_init:
beq end
mov r1, r0
ldr r0, [sp, #4]
+ and sp, sp, #0xfffffff0
Review comment:
I might have misunderstood, so feel free to ignore this comment. Should
this be `0xfffffff8` instead of `0xfffffff0`? Currently, this ensures the
stack pointer is a multiple of 16, but I thought the intent was to ensure it is
a multiple of eight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
