andrzej-kaczmarek commented on issue #573: Move SPI and I2C config definitions 
from BSPs to MCUs.
URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332189346
 
 
   correct me if I'm wrong but SPI_0_MASTER_SS_PIN is a slave select pin so 
basically it can be virtually any pin which application controls anyway. so it 
should not be defined at mcu level as it does not make much sense there and 
honestly I'd remove this definition entirely. I see this syscfg val is only 
used now by lora driver, but in this case this driver should have its own 
syscfg val for defining SS pin number.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to