sjanc commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141575355
 
 

 ##########
 File path: net/nimble/host/mesh/src/cfg.c
 ##########
 @@ -2913,6 +2913,8 @@ static void heartbeat_sub_set(struct bt_mesh_model 
*model,
 
        if (period_ms) {
                cfg->hb_sub.expiry = k_uptime_get() + period_ms;
+       } else {
+               cfg->hb_sub.expiry = k_uptime_get();
        }
 
 Review comment:
   you could just do
   cfg->hb_sub.expiry = k_uptime_get() + period_ms;
   
   without if-else
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to