jhedberg commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141641730
##########
File path: net/nimble/host/mesh/src/cfg.c
##########
@@ -2913,6 +2913,8 @@ static void heartbeat_sub_set(struct bt_mesh_model
*model,
if (period_ms) {
cfg->hb_sub.expiry = k_uptime_get() + period_ms;
+ } else {
+ cfg->hb_sub.expiry = k_uptime_get();
}
Review comment:
Also note that this is not about invalid parameters. Messages with invalid
parameters should not yield any reaction at all by the implementation. Instead,
this particular code path is about disabling the subscription.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
