sjanc commented on a change in pull request #605: nimble/ll: Fix scheduling of extended advertising events URL: https://github.com/apache/mynewt-core/pull/605#discussion_r144289838
########## File path: net/nimble/controller/src/ble_ll_adv.c ########## @@ -118,13 +119,27 @@ struct ble_ll_adv_sm #define BLE_LL_ADV_SM_FLAG_RX_ADD 0x02 #define BLE_LL_ADV_SM_FLAG_SCAN_REQ_NOTIF 0x04 #define BLE_LL_ADV_SM_FLAG_CONN_RSP_TXD 0x08 -#define BLE_LL_ADV_SM_FLAG_SECONDARY 0x10 +#define BLE_LL_ADV_SM_FLAG_ACTIVE_CHANSET 0x30 /* use helpers to get/set */ Review comment: This flag is 2bit wide so put comment here :) or maybe just name it mask ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services