andrzej-kaczmarek commented on a change in pull request #605: nimble/ll: Fix
scheduling of extended advertising events
URL: https://github.com/apache/mynewt-core/pull/605#discussion_r144296470
##########
File path: net/nimble/controller/src/ble_ll_adv.c
##########
@@ -1230,11 +1282,8 @@ ble_ll_adv_sm_stop(struct ble_ll_adv_sm *advsm)
if (advsm->adv_enabled) {
/* Remove any scheduled advertising items */
ble_ll_sched_rmv_elem(&advsm->adv_sch);
-
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
- if (!(advsm->props & BLE_HCI_LE_SET_EXT_ADV_PROP_LEGACY)) {
- ble_ll_sched_rmv_elem(&advsm->adv_secondary_sch);
- }
+ ble_ll_sched_rmv_elem(&advsm->adv_secondary_sch);
Review comment:
for legacy we won't have anything scheduled on aux so this call won't do
anything - the result will be the same with and without flag so just removed it
since I use similar "logic" in other places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
