microbuilder commented on a change in pull request #1251: Added stubs for I2C simulation URL: https://github.com/apache/mynewt-core/pull/1251#discussion_r201617792
########## File path: hw/hal/include/hal/hal_i2c_sim.h ########## @@ -0,0 +1,108 @@ +/* Review comment: Just moved this file and renamed it, but should I rename all of the functions as well to start with `mcu_sim_i2c` rather than the current `hal_i2c_sim`? The current function names now conflict with the file name, BUT I personally think that it's useful to make it clear that the functions here are implementing hal_i2c signatures. I'll follow your lead if you want me to change all the names to match the filename though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
