amrbekhit commented on issue #1286: Add support for the Bosch BME680 Environmental Sensor URL: https://github.com/apache/mynewt-core/pull/1286#issuecomment-410025034 The pointers are initialised in bme680_config so that they point to either the spi or i2c functions. The driver then calls these without worrying about the interface. On Thu, 2 Aug 2018, 8:58 p.m. Vipul Rahane, <[email protected]> wrote: > *@vrahane* commented on this pull request. > > Generally, looks good to me. The only thing that kind of confuses me is > why the following are declared as function pointers: > > /*! Bus read function pointer */ > bme680_com_fptr_t read; > /*! Bus write function pointer */ > bme680_com_fptr_t write; > /*! delay function pointer */ > bme680_delay_fptr_t delay_ms; > > Rest looks good. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/mynewt-core/pull/1286#pullrequestreview-142908793>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHOO6dbhe7bvQmPYSniWMZ-YCp0pN1gSks5uMz3YgaJpZM4VXs4_> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
