rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r257612951
########## File path: nimble/host/src/ble_gap.c ########## @@ -1353,15 +1477,15 @@ ble_gap_rx_conn_complete(struct hci_le_conn_complete *evt, uint8_t instance) STATS_INC(ble_gap_stats, rx_conn_complete); - /* in that case *only* status field is valid so we determine role Review comment: There is a lot of changes from here down to the end of the file which are not relevant. Please remove them from this patch. It is already big patch and let's don't make it bigger. Could you please prepare instead a patch with a coding style fixes instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services