kasjer commented on a change in pull request #1743: Additional Wake Up / Reset
Reason
URL: https://github.com/apache/mynewt-core/pull/1743#discussion_r272498230
##########
File path: hw/hal/include/hal/hal_system.h
##########
@@ -66,8 +66,10 @@ enum hal_reset_reason {
HAL_RESET_SOFT = 4,
/** Low supply voltage */
HAL_RESET_BROWNOUT = 5,
+ /** Power on */
Review comment:
I would change it to HAL_RESET_SYSTEM_OFF or such. Now we have comment
stating Power on (which is double confusing: first see comment on
HAL_RESET_POR, second name is HAL_RESET_POWER_OFF)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
