wes3 commented on a change in pull request #1868: hw/mcu/dialog: SNC URL: https://github.com/apache/mynewt-core/pull/1868#discussion_r294492616
########## File path: hw/mcu/dialog/da1469x/src/da1469x_snc.c ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <assert.h> +#include "mcu/mcu.h" +#include "mcu/da1469x_snc.h" + +int +snc_sw_init(void) Review comment: Actually, I have a comment about this one. So, there is a signal from the SNC called SNC_DONE that goes to the PDC. In the case where the device is SW controlled that signal will still come from the SNC but you will still have to manually release the COM domain with da1469x_pd_release(). Since there is no specific API to release the SNC from SW control it seems a bit odd to have the SNC code acquire but not release the COM domain. So I think we have two choices here: 1) The user must separately call pd_acquire and pd_release. 2) Add an API to the SNC code that releases the SNC from SW control. This would call pd_release. I am leaning towards 2). Do you have a preference? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
