jhedberg commented on a change in pull request #488: nimble/mesh: Fix
provisioning errors handling
URL: https://github.com/apache/mynewt-nimble/pull/488#discussion_r297131481
##########
File path: nimble/host/mesh/src/prov.c
##########
@@ -1195,6 +1221,12 @@ static void prov_retransmit(struct ble_npl_event *work)
}
}
+static void prot_tmo_link_close(struct ble_npl_event *ev)
+{
+ close_link(PROV_ERR_UNEXP_ERR, CLOSE_REASON_FAILED);
+ reset_link();
Review comment:
`reset_link()` is a PB-ADV specific internal API, so calling it from this
function doesn't seem correct. Also, passing a non-zero first parameter to
`close_link()` doesn't seem right since that would cause a second (duplicate)
failure message to be sent. It would also be in violation of the spec text " In
the case of protocol timeout, the device shall not send a Provisioning Failed
PDU.".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
