andrzej-kaczmarek commented on a change in pull request #499: nimble/mesh: Reject invalid remote public key URL: https://github.com/apache/mynewt-nimble/pull/499#discussion_r297141300
########## File path: nimble/host/src/ble_sm_alg.c ########## @@ -418,6 +418,21 @@ ble_sm_alg_g2(uint8_t *u, uint8_t *v, uint8_t *x, uint8_t *y, return 0; } +int +ble_sm_alg_valid_pub_key(uint8_t *peer_pub_key_x, uint8_t *peer_pub_key_y) Review comment: I'd call this either ...is_valid_pub_key and just return bool or ...check_pub_key and return error code and both parameters can be const ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services