haukepetersen commented on a change in pull request #508: npl/riot: strip down the default configuration URL: https://github.com/apache/mynewt-nimble/pull/508#discussion_r300701575
########## File path: porting/npl/riot/include/syscfg/syscfg.h ########## @@ -830,7 +830,8 @@ #endif #ifndef MYNEWT_VAL_BLE_L2CAP_MAX_CHANS -#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS (3*MYNEWT_VAL_BLE_MAX_CONNECTIONS) +#define MYNEWT_VAL_BLE_L2CAP_MAX_CHANS ((2 + MYNEWT_VAL_BLE_SM_SC) * \ Review comment: But in the current configuration, SM is not compiled in, right? So I figured there is no need to allocate the corresponding L2CAP channel - despite from not being standards compliant. Or is there anything in the code I missed that depends on all 3 channels being allocated even if the SM is missing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
