andrzej-kaczmarek commented on a change in pull request #1959: Nrf52840 spi 3
URL: https://github.com/apache/mynewt-core/pull/1959#discussion_r316053572
##########
File path: hw/mcu/nordic/nrf52xxx/src/hal_spi.c
##########
@@ -110,21 +110,17 @@ anomaly_198_enable(uint8_t const * p_buffer, size_t
buf_len)
{
m_anomaly_198_preserved_value = *((volatile uint32_t *)0x40000E00);
- if (buf_len == 0)
- {
+ if (buf_len == 0) {
return;
}
uint32_t buffer_end_addr = ((uint32_t)p_buffer) + buf_len;
uint32_t block_addr = ((uint32_t)p_buffer) & ~0x1FFF;
uint32_t block_flag = (1UL << ((block_addr >> 13) & 0xFFFF));
uint32_t occupied_blocks = 0;
Review comment:
local variables definitions should be also moved to top of function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
