vrahane commented on a change in pull request #1917: Use SMP/OMP/MCUmgr, remove
newtmgr and change OICMGR to use OMP
URL: https://github.com/apache/mynewt-core/pull/1917#discussion_r332298699
##########
File path: test/crash_test/src/crash_mgmt.c
##########
@@ -64,17 +74,19 @@ crash_test_nmgr_write(struct mgmt_cbuf *cb)
return MGMT_ERR_EINVAL;
}
- rc = crash_device(tmp_str);
+ rc = crash_verify_cmd(how_str);
if (rc != 0) {
return MGMT_ERR_EINVAL;
}
- rc = mgmt_cbuf_setoerr(cb, 0);
- if (rc != 0) {
- return rc;
- }
+ os_callout_init(&mynewt_os_mgmt_crash_callout, os_eventq_dflt_get(),
+ crash_cb, NULL);
+
+ os_callout_reset(&mynewt_os_mgmt_crash_callout,
+ delay_ms * OS_TICKS_PER_SEC / 1000);
+
Review comment:
resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
