vrahane commented on a change in pull request #1917: Use SMP/OMP/MCUmgr, remove newtmgr and change OICMGR to use OMP URL: https://github.com/apache/mynewt-core/pull/1917#discussion_r332302157
########## File path: mgmt/mgmt/include/mgmt/mgmt.h ########## @@ -1,128 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -#ifndef _MGMT_MGMT_H_ -#define _MGMT_MGMT_H_ - -#include <inttypes.h> -#include "os/mynewt.h" - -#ifdef __cplusplus -extern "C" { -#endif - -/* MTU for newtmgr responses */ -#define MGMT_MAX_MTU 1024 - -/* NLIP packets sent over serial are fragmented into frames of 127 bytes or - * fewer. This 127-byte maximum applies to the entire frame, including header, - * CRC, and terminating newline. - */ -#define MGMT_NLIP_MAX_FRAME 127 Review comment: added in the smp_uart.c source file ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
