mkiiskila commented on a change in pull request #1917: Use SMP/OMP/MCUmgr,
remove newtmgr and change OICMGR to use OMP
URL: https://github.com/apache/mynewt-core/pull/1917#discussion_r333376168
##########
File path: mgmt/smp/transport/smp_uart/src/smp_uart.c
##########
@@ -354,42 +360,42 @@ nmgr_uart_rx_char(void *arg, uint8_t data)
}
}
/* failed */
- nus->nus_rx->omp_len = 0;
+ sus->sus_rx->omp_len = 0;
m->om_len = 0;
os_mbuf_free_chain(SLIST_NEXT(m, om_next));
SLIST_NEXT(m, om_next) = NULL;
return 0;
}
void
-nmgr_uart_pkg_init(void)
+smp_uart_pkg_init(void)
{
- struct nmgr_uart_state *nus = &nmgr_uart_state;
+ struct smp_uart_state *sus = &smp_uart_state;
int rc;
struct uart_conf uc = {
.uc_speed = MYNEWT_VAL(NMGR_UART_SPEED),
Review comment:
This was for low memory platforms which could not fit shell/did not want
shell. I've used it, I would have liked to keep it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
