sjanc commented on a change in pull request #639: nimble/ll: Fix extended
scanner data fragmentation issues
URL: https://github.com/apache/mynewt-nimble/pull/639#discussion_r343329572
##########
File path: nimble/controller/src/ble_ll_scan.c
##########
@@ -1205,11 +1204,9 @@ ble_ll_scan_aux_data_unref(struct ble_ll_aux_data
*aux_data)
ble_ll_trace_u32x2(BLE_LL_TRACE_ID_AUX_UNREF, (uint32_t) aux_data,
aux_data->ref_cnt);
if (aux_data->ref_cnt == 0) {
- /* Below assert is to detect missing complete or truncated event in
case of chaining */
- BLE_LL_ASSERT(!((BLE_LL_AUX_CHECK_FLAG(aux_data, BLE_LL_AUX_CHAIN_BIT)
&&
- BLE_LL_AUX_CHECK_FLAG(aux_data,
BLE_LL_SENT_EVENT_TO_HOST)) &&
- !(BLE_LL_AUX_CHECK_FLAG(aux_data,
BLE_LL_AUX_TRUNCATED_SENT) ||
- !BLE_LL_AUX_CHECK_FLAG(aux_data,
BLE_LL_AUX_INCOMPLETE_BIT))));
+ BLE_LL_ASSERT(!(aux_data->flags_ll & BLE_LL_AUX_FLAG_SCAN_ERROR) ||
Review comment:
I'm not sure if this is doing what it is suppose to do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
