andrzej-kaczmarek commented on a change in pull request #744: [WIP] Add support for Enhanced LE CoC as per BT 5.2 URL: https://github.com/apache/mynewt-nimble/pull/744#discussion_r375268931
########## File path: nimble/host/include/host/ble_l2cap.h ########## @@ -219,11 +254,16 @@ int ble_l2cap_create_server(uint16_t psm, uint16_t mtu, int ble_l2cap_connect(uint16_t conn_handle, uint16_t psm, uint16_t mtu, struct os_mbuf *sdu_rx, ble_l2cap_event_fn *cb, void *cb_arg); +int ble_l2cap_connect_multiple(uint16_t conn_handle, + uint16_t psm, uint16_t mtu, + uint8_t num, struct os_mbuf *sdu_rx[num], + ble_l2cap_event_fn *cb, void *cb_arg); int ble_l2cap_disconnect(struct ble_l2cap_chan *chan); int ble_l2cap_send(struct ble_l2cap_chan *chan, struct os_mbuf *sdu_tx); int ble_l2cap_recv_ready(struct ble_l2cap_chan *chan, struct os_mbuf *sdu_rx); int ble_l2cap_get_chan_info(struct ble_l2cap_chan *chan, struct ble_l2cap_chan_info *chan_info); - +int ble_l2cap_reconfig(uint16_t conn_handle, uint16_t new_mtu, + uint8_t cnt, struct ble_l2cap_chan *chans[]); Review comment: cnt -> num I think both new APIs should be added below existing APIs and have comment that they require 5.2 feature to work, otherwise one might think that this works using "old" coc sig messages ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services