utzig commented on a change in pull request #2184: crypto/mbedtls: Enable AES
and SECP256R1
URL: https://github.com/apache/mynewt-core/pull/2184#discussion_r383770897
##########
File path: hw/drivers/trng/trng_da1469x/src/trng_da1469x.c
##########
@@ -105,3 +106,23 @@ da1469x_trng_init(struct os_dev *dev, void *arg)
return 0;
}
+
+#ifdef MBEDTLS_ENTROPY_HARDWARE_ALT
+int
+mbedtls_hardware_poll(void *data, unsigned char *output, size_t len, size_t
*olen)
Review comment:
This would be way better if it was located in
`hw/drivers/trng/src/mbed_entropy_alt.c` (or any other similar name) so that it
would be automatically usable by all `trng` drivers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
