apache-mynewt-bot removed a comment on pull request #2286: URL: https://github.com/apache/mynewt-core/pull/2286#issuecomment-626709617
<!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### sys/memfault/src/memfault_platform_core.c <details> ```diff @@ -30,9 +30,11 @@ void memfault_platform_halt_if_debugging(void) { -// if (hal_debugger_connected()) { -// __asm("bkpt"); -// } +/* + if (hal_debugger_connected()) { + __asm("bkpt"); + } + */ } void @@ -49,7 +51,7 @@ metrics_period_sec = period_sec; metrics_callback = callback; metrics_callout_cb(NULL); - return true; // indicates setup was successful + return true; /* indicates setup was successful */ } uint64_t @@ -74,20 +76,22 @@ const sMemfaultEventStorageImpl *evt_storage = memfault_events_storage_boot(s_event_storage, sizeof(s_event_storage)); - // Pass the storage to collect reset info + /* Pass the storage to collect reset info */ memfault_reboot_tracking_collect_reset_info(evt_storage); - // Pass the storage to initialize the trace event module + /* Pass the storage to initialize the trace event module */ memfault_trace_event_boot(evt_storage); - // NOTE: crash count represents the number of unexpected reboots since the - // last heartbeat was reported. In the simplest case if reboots are - // unexpected, this can just be set to 1 but see memfault/metrics/metrics.h - // how this can be tracked with the reboot_tracking module. + /* + NOTE: crash count represents the number of unexpected reboots since the + last heartbeat was reported. In the simplest case if reboots are + unexpected, this can just be set to 1 but see memfault/metrics/metrics.h + how this can be tracked with the reboot_tracking module. + */ sMemfaultMetricBootInfo boot_info = { .unexpected_reboot_count = memfault_reboot_tracking_get_crash_count() }; rc = memfault_metrics_boot(evt_storage, &boot_info); - // NOTE: a non-zero value indicates a configuration error took place + /* NOTE: a non-zero value indicates a configuration error took place */ SYSINIT_PANIC_ASSERT(rc == 0); memfault_reboot_tracking_reset_crash_count(); ``` </details> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
