kasjer commented on a change in pull request #2319:
URL: https://github.com/apache/mynewt-core/pull/2319#discussion_r443343610
##########
File path: hw/mcu/stm/stm32_common/syscfg.yml
##########
@@ -262,3 +262,7 @@ syscfg.defs:
ADC_2:
description: "ADC_2"
value: 0
+
+ OS_TICKS_PER_SEC:
+ description:
Review comment:
Description not provided.
##########
File path: hw/mcu/stm/stm32f1xx/src/system_stm32f1xx.c
##########
@@ -69,6 +69,12 @@ void SystemClock_Config(void);
void
SystemInit(void)
{
+ /* Reset all peripherals. */
+ RCC->APB1RSTR = 0xFFFFFFFF;
+ RCC->APB2RSTR = 0xFFFFFFFF;
+ RCC->APB1RSTR = 0x00000000;
+ RCC->APB2RSTR = 0x00000000;
+
Review comment:
This code does not seem to be relevant to the change, isn't it?
##########
File path: hw/mcu/stm/stm32_common/src/hal_os_tick.c
##########
@@ -20,6 +20,7 @@
#include <assert.h>
#include "os/mynewt.h"
#include <hal/hal_os_tick.h>
+#include <stm32_common/stm32_hal.h>
/*
* XXX implement tickless mode.
Review comment:
PR seems to make this comment partially obsolete :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
