[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2351: PineTime SPI flash

[GitBox]

apache-mynewt-bot removed a comment on pull request #2351:
URL: https://github.com/apache/mynewt-core/pull/2351#issuecomment-670849441


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/pinetime/src/hal_bsp.c
   <details>
   
   ```diff
   @@ -59,21 +59,21 @@
    #if MYNEWT_VAL(SPIFLASH)
    #if MYNEWT_VAL(BUS_DRIVER_PRESENT)
    struct bus_spi_node_cfg flash_spi_cfg = {
   -        .node_cfg.bus_name = MYNEWT_VAL(BSP_FLASH_SPI_BUS),
   -        .pin_cs = MYNEWT_VAL(SPIFLASH_SPI_CS_PIN),
   -        .mode = BUS_SPI_MODE_3,
   -        .data_order = HAL_SPI_MSB_FIRST,
   -        .freq = MYNEWT_VAL(SPIFLASH_BAUDRATE),
   +    .node_cfg.bus_name = MYNEWT_VAL(BSP_FLASH_SPI_BUS),
   +    .pin_cs = MYNEWT_VAL(SPIFLASH_SPI_CS_PIN),
   +    .mode = BUS_SPI_MODE_3,
   +    .data_order = HAL_SPI_MSB_FIRST,
   +    .freq = MYNEWT_VAL(SPIFLASH_BAUDRATE),
    };
    #endif
    #endif
    
    static const struct hal_flash *flash_devs[] = {
        /* MCU internal flash. */
   -    [0] = &nrf52k_flash_dev,  //  Internal Flash ROM
   +    [0] = &nrf52k_flash_dev,  /*  Internal Flash ROM */
    #if MYNEWT_VAL(SPIFLASH)
        /* BSP external flash. */
   -    [1] = &spiflash_dev.hal,  //  External SPI Flash
   +    [1] = &spiflash_dev.hal,  /*  External SPI Flash */
    #endif
    };
    
   @@ -184,15 +184,16 @@
    #if MYNEWT_VAL(BUS_DRIVER_PRESENT)
    static struct bus_spi_node hal_bsp_display_spi;
    struct bus_spi_node_cfg hal_bsp_display_spi_cfg = {
   -        .node_cfg.bus_name = MYNEWT_VAL(BSP_FLASH_SPI_BUS),
   -        .pin_cs = LCD_CHIP_SELECT_PIN,
   -        .mode = BUS_SPI_MODE_3,
   -        .data_order = HAL_SPI_MSB_FIRST,
   -        .freq = 8000,
   +    .node_cfg.bus_name = MYNEWT_VAL(BSP_FLASH_SPI_BUS),
   +    .pin_cs = LCD_CHIP_SELECT_PIN,
   +    .mode = BUS_SPI_MODE_3,
   +    .data_order = HAL_SPI_MSB_FIRST,
   +    .freq = 8000,
    };
    
    static void
   -hal_bsp_display_spi_init(void) {
   +hal_bsp_display_spi_init(void)
   +{
        int rc;
    
        rc = bus_spi_node_create("spidisplay", &hal_bsp_display_spi, 
&hal_bsp_display_spi_cfg, NULL);
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org