vrahane commented on a change in pull request #2376: URL: https://github.com/apache/mynewt-core/pull/2376#discussion_r489885691
########## File path: hw/drivers/sensors/bmp388/src/bmp388.c ########## @@ -3366,6 +3366,215 @@ bmp388_stream_read(struct sensor *sensor, return rc; } +int +bmp388_hybrid_read(struct sensor *sensor, + sensor_type_t sensor_type, + sensor_data_func_t read_func, + void *read_arg, + uint32_t time_ms) +{ + int rc; + struct bmp388 *bmp388; + struct bmp388_cfg *cfg; + os_time_t time_ticks; + os_time_t stop_ticks = 0; + uint16_t try_count; + +#if MYNEWT_VAL(BMP388_FIFO_ENABLE) + /* FIFO object to be assigned to device structure */ + struct bmp3_fifo fifo; + /* Pressure and temperature array of structures with maximum frame size */ + struct bmp3_data sensor_data[74]; Review comment: sensor_time is not part of the FIFO frames, as per the BMP388 Datasheet "The data for the sensor-time frame consists of register sensor_time content at the time the sensortime frame transmission has started. A sensor-time frame is not stored in the FIFO, but append to every FIFO burst read operation after all data has been transmitted if fifo_time_en=‘1’." ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org