agross-korg commented on a change in pull request #2392:
URL: https://github.com/apache/mynewt-core/pull/2392#discussion_r506712358
##########
File path: hw/drivers/crypto/crypto_da1469x/src/crypto_da1469x.c
##########
@@ -73,7 +74,10 @@ do_dma_key_tx(const void *key, uint16_t keylen)
da1469x_otp_set_mode(OTPC_MODE_READ);
/* securely DMA hardware key from secret storage to QSPI decrypt engine */
- dma_regs->DMA_REQ_MUX_REG |= 0xf000;
+ OS_ENTER_CRITICAL(sr);
+ /* Use the secure channel #7 */
+ MCU_DMA_SET_MUX(7, MCU_DMA_PERIPH_NONE);
Review comment:
never mind ignoring the fact that we only have 8 channels, we dont have
protections on the peripheral being 0-15, or the channel even being valid.
What happens if someone asks for 9.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
