caspermeijn commented on a change in pull request #2430:
URL: https://github.com/apache/mynewt-core/pull/2430#discussion_r539636969
##########
File path: net/ip/native_sockets/syscfg.yml
##########
@@ -27,7 +27,7 @@ syscfg.defs:
description: >
The frequency at which to poll for received data. Units
are OS ticks.
- value: 'OS_TICKS_PER_SEC / 5'
+ value: 'MYNEWT_VAL(OS_TICKS_PER_SEC) / 5'
Review comment:
The `MYNEWT_VAL` macro is not needed, right? As `os_time.h` defines
`OS_TICKS_PER_SEC`. So as long as all users of `NATIVE_SOCKETS_POLL_ITVL`
include `os_time.h` it would work.
Or is the problem that you need a `MYNEWT_VAL` to evaluate the `MYNEWT_VAL`?
Because that would still be needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
